-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Github CI #19
Add Github CI #19
Conversation
.github/workflows/run-litmus.yml
Outdated
- name: Run litmus tests via CLI | ||
run: ./cli/build/bin/linuxX64/releaseExecutable/cli.kexe -r pthread ".*" | ||
- name: Run a single test with JCStress | ||
run: ./gradlew :cli:jvmRun --args="-r jcstress -j '-m quick' StoreBuffering.Plain" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not run all jcstress tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DLochmelis33 ping
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussed this on a meeting.
The problem is that apparently there is no option in jcstress to control the duration of testing, except the -m
(mode) option. But, event with -m quick
all the tests that we have now are run ~30mins, which is too long.
The purpose of our local CI is to run "smoke-tests" of the litmuskt
tool itself (i.e. to quickly check the basic functionality of the tool), and not to exhaustively test the Kotlin compiler.
Therefore, it was decided to run just a single jcstress test on CI, only to check that the jcstress integration works.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DLochmelis33 could you please add the info from the comment above to the code.
After this we can merge this PR.
Added the comment, decided to let JCStress run all tests, found a couple of bugs, fixed them |
The current CI fails on MacOS because of the new UPUB bug